fix(log): await cleanup and sort files before deletion #7245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cleanup()ininit()to prevent race condition where cleanup could run concurrently with file creationProblem
Log files were being deleted immediately after creation due to two issues:
cleanup()was called fire-and-forget (not awaited), creating a race conditionBun.Glob.scan()returns files in arbitrary filesystem order, soslice(0, -10)was deleting random files instead of the oldest onesFix
awaitbeforecleanup()call.sort()before.slice(0, -10)to ensure lexicographic order (which matches chronological order for theYYYY-MM-DDTHHMMSS.logfilename format)Tests
Added 8 tests covering: