refactor(ripgrep): split into modular directory structure #7453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract platform config, download, and extraction into separate functions - Split extraction logic into extractPosix and extractWindows - Simplify filepath export by removing unnecessary wrapper - Replace deprecated Bun.readableStreamToText with Response.text() - Remove duplicate conditional check for zip extraction
- Group all exports at bottom of file with clear sections - Extract buildFilesArgs helper for ripgrep argument construction - Extract streamLines helper for async line streaming - Add FilesInput interface and MAX_BUFFER_BYTES constant - Rename internal Match schema to MatchSchema to avoid conflict
Split ripgrep.ts into a directory structure for better organization: - binary.ts: Platform config, download, extract, filepath - schema.ts: Zod schemas for ripgrep JSON output - tree.ts: TreeNode interface and tree helpers (build, sort, truncate, render) - index.ts: Public API (files, tree, search) and re-exports
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Related PR Found:
This PR (#6507) may have relevant changes to the tree building logic that should be considered alongside the refactoring in PR #7453. However, they appear to be addressing different concerns (optimization vs. modularization), so they may be complementary rather than duplicate. |
Replace shell command execution with Bun.spawn to avoid cross-platform shell quoting issues. The previous approach used embedded single quotes in glob patterns which behaved differently on macOS vs Ubuntu.
vtemian
force-pushed
the
cleanup/ripgrep-refactor
branch
from
95a3715 to
5f467a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ripgrep.ts(400+ lines) into modular directory structureGlobal.Platformhelpers for cross-platform binary handlingChanges
src/file/ripgrep.ts→src/file/ripgrep/index.ts- Public API (files, tree, search, rg)binary.ts- Binary download/extraction logictree.ts- Tree building and BFS truncationio.ts- Stream line parsing utilitysrc/global/index.ts- AddedPlatform.isWindowsandPlatform.binExttest/file/ripgrep.test.ts- 14 integration tests