fix(structured outputs): avoid including beta header if output_format is missing
#1121
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@RobertCraigie merge it please if it's ready. I can't merge unfortunately, even the approved ones 😢 |
Collaborator
|
Ah sorry I forgot you can't do that yet :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third-party clients (Vertex, Bedrock) don’t support structured outputs and its beta header, so when the SDK sets it, the remote server returns
Error code: 400 - {'message': 'invalid beta flag'}.This change just avoids always setting that header, so we can still port the
tool_runnerandstreamhelpers, which useparsemethod internally, with minimal changes.