fix: read error field from top-level data, not message object #508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #505
The
AssistantMessage.errorfield was never being populated because the message parser was reading from the wrong location in the JSON structure.Problem
The CLI outputs error information at the top level of the JSON, not inside the
messageobject:{ "type": "assistant", "message": { "content": [...], "model": "..." }, "session_id": "...", "uuid": "...", "error": "unknown" // <-- error is HERE at top level }The previous fix (PR #405) incorrectly read from
data["message"].get("error")instead ofdata.get("error").Solution
Changed the parser to read error from the correct location:
Testing
test_parse_assistant_message_with_error- general errorstest_parse_assistant_message_with_rate_limit_error- rate limit detectiontest_parse_assistant_message_with_auth_error- authentication errorsUsage Example
After this fix, applications can properly detect and handle errors: