chore: Remove pr_comment GitHub actions workflow #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
pull_request_targettrigger, which goes against the ASF GitHub Actions Policy.From reading https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/, my understanding is that we're using
pull_request_targetcorrectly here by not checking out untrusted code. We need to use this target instead ofpull_requestto have permission to comment on the PR.The ASF automated check seems too strict to me, but I'm not sure it's worth the hassle to challenge this and we can work without this workflow.
Maybe as an alternative, we could add something to the pull request template that's commented out by default but users can uncomment and edit if they're making documentation changes? I can add that in a follow-up PR.
cc @kou