MINOR: [Docs] Update docs to point to separate Java codebase#45134
MINOR: [Docs] Update docs to point to separate Java codebase#45134kou merged 4 commits intoapache:mainfrom
Conversation
|
These changes are pretty trivial + are mainly for docs that aren't specifically related to java. Though one remaining issue is that the following pages/sub-pages still live in this repo which I assume isn't desired 🤔 . |
|
@github-actions crossbow submit preview-docs |
|
Revision: 1a0d89952832dc4ec94e4b9fbee3f4645aa4e05f Submitted crossbow builds: ursacomputing/crossbow @ actions-c3413aeb10
|
|
Could you also update |
|
@github-actions crossbow submit preview-docs |
|
There was a problem hiding this comment.
Building JNI libs with maven is broken until the pom.xml file is updated in arrow-java to avoid passing -S java to cmake among other problems.
There was a problem hiding this comment.
Yup, I'll wait on apache/arrow-java#449.
Will this order work?
- GH-13: Set up JNI build (dataset, etc.) arrow-java#449 lands
- I'll try to verify each build path and update the docs on this PR -> merge it into apache/arrow
[Docs] Migrate java development and usage docs from apache/arrow arrow-java#472[Doc] Generate Java documentation arrow-java#455 (I can try to cherry-pick the commits in the docs in a similar way that was done for the source code)- Remove java docs from apache/arrow
There was a problem hiding this comment.
Bit unfamiliar with archery, but I couldn't find any directives/targets for java-jni-manylinux-2014 in any of the dockerfiles between both repos.
There was a problem hiding this comment.
We can use docker compose instead of Archery.
apache/arrow-java uses docker compose directly instead of via Archery.
There was a problem hiding this comment.
Ah I see, after apache/arrow-java#449 I can replace the archery sections with docker compose
Updated + tweaked the build instructions for the JNI libraries. I commented on this review a few more problems in the "building Java" docs. Some need source fixes to be done in arrow-java - could these updates be made once the java documentation has moved to apache/arrow-java maybe? |
|
@github-actions crossbow submit preview-docs |
|
Revision: 197369e7e47c028314eafa538a3670f0907dfe79 Submitted crossbow builds: ursacomputing/crossbow @ actions-88de21002f
|
|
Apologies was a bit delayed here. I see that building.rst has been moved to arrow-java in https://github.com/apache/arrow-java/pull/553/files. A significant portion of that file needs to be updated - even with the existing changes I have in this PR. Given the above, could I leave building.rst out of this PR? The other two updates are for files that will remain in this repo. |
|
Yes, please. |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
197369e to
26a6cf8
Compare
|
Reverted building.rst changes |
|
@github-actions crossbow submit preview-docs |
|
Revision: 26a6cf8 Submitted crossbow builds: ursacomputing/crossbow @ actions-ba09884753
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aaa88e9. There were 8 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Post #44945 the Java implementation lives in it's own repo. Update docs
to point there.
What changes are included in this PR?
Updates to a few locations that reference old Java impl location.
Are these changes tested?
Rendered the Sphinx ones locally to check.
Are there any user-facing changes?
No