GH-35437: [C++] Remove obsolete TODO about DictionaryArray const& return types #48956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HyukjinKwon
commented
Jan 23, 2026
| const auto& dict_array = checked_cast<const DictionaryArray&>(array); | ||
| // TODO: These methods should probably return a const&? They seem capable. | ||
| // https://github.com/apache/arrow/issues/35437 | ||
| auto dict_values = dict_array.dictionary(); |
Member
Author
There was a problem hiding this comment.
probably can be const auto but let me don't mix it with the current issue.
Member
There was a problem hiding this comment.
Just make them both const auto&?
github-actions
bot
added
Component: C++
awaiting review
pitrou
reviewed
Jan 26, 2026
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Thanks for this, just a small suggestion.
| const auto& dict_array = checked_cast<const DictionaryArray&>(array); | ||
| // TODO: These methods should probably return a const&? They seem capable. | ||
| // https://github.com/apache/arrow/issues/35437 | ||
| auto dict_values = dict_array.dictionary(); |
Member
There was a problem hiding this comment.
Just make them both const auto&?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The TODO comment in
vector_array_sort.ccasking whetherDictionaryArray::dictionary()andDictionaryArray::indices()should returnconst&has been obsolete.It was added in commit 6ceb12f when dictionary array sorting was implemented. At that time, these methods returned
std::shared_ptr<Array>by value, causing unnecessary copies.The issue was fixed in commit 95a8bfb which changed both methods to return
const std::shared_ptr<Array>&, removing the copies. However, the TODO comment was left unremoved.What changes are included in this PR?
Removed the outdated TODO comment that referenced GH-35437.
Are these changes tested?
I did not test.
Are there any user-facing changes?
No.