GH-48983: [Packaging][Python] Ensure and add LICENSE.txt and NOTICE.txt to Python wheels

[raulcd]

Rationale for this change

Currently the files are missing from the published wheels.

What changes are included in this PR?

• Ensure the license and notice files are part of the wheels
• Manually copy the LICENSE.txt and NOTICE.txt when building wheels.

Are these changes tested?

Yes, via archery.
I've validated all wheels will fail with the new check if LICENSE.txt or NOTICE.txt are missing:

 AssertionError: LICENSE.txt is missing from the wheel.

Are there any user-facing changes?

No

• GitHub Issue: [Python][Packaging] Missing license files in 23.0.0 wheels #48983

[github-actions]

⚠️ GitHub issue #48983 has been automatically assigned in GitHub to PR creator.

[raulcd]

@github-actions crossbow submit wheel-313--amd64

[github-actions]

Revision: 070ac9d

Submitted crossbow builds: ursacomputing/crossbow @ actions-b8c9cec4c2

Task	Status
wheel-macos-monterey-cp313-cp313-amd64
wheel-macos-monterey-cp313-cp313t-amd64
wheel-manylinux-2-28-cp313-cp313-amd64
wheel-manylinux-2-28-cp313-cp313t-amd64
wheel-musllinux-1-2-cp313-cp313-amd64
wheel-musllinux-1-2-cp313-cp313t-amd64
wheel-windows-cp313-cp313-amd64
wheel-windows-cp313-cp313t-amd64

[raulcd]

@github-actions crossbow submit wheel-manylinux-2-28-cp313-cp313-amd64

[github-actions]

Revision: 9566c3b

Submitted crossbow builds: ursacomputing/crossbow @ actions-9fe4dfb4ec

Task	Status
wheel-manylinux-2-28-cp313-cp313-amd64

[raulcd]

@github-actions crossbow submit wheel-manylinux-2-28-cp313-cp313-amd64

[github-actions]

Revision: 8ae2c1c

Submitted crossbow builds: ursacomputing/crossbow @ actions-722266c345

Task	Status
wheel-manylinux-2-28-cp313-cp313-amd64

[raulcd]

@github-actions crossbow submit wheel-313

[github-actions]

Revision: 8ae2c1c

Submitted crossbow builds: ursacomputing/crossbow @ actions-a71739e7f4

Task	Status
wheel-macos-monterey-cp313-cp313-amd64
wheel-macos-monterey-cp313-cp313-arm64
wheel-macos-monterey-cp313-cp313t-amd64
wheel-macos-monterey-cp313-cp313t-arm64
wheel-manylinux-2-28-cp313-cp313-amd64
wheel-manylinux-2-28-cp313-cp313-arm64
wheel-manylinux-2-28-cp313-cp313t-amd64
wheel-manylinux-2-28-cp313-cp313t-arm64
wheel-musllinux-1-2-cp313-cp313-amd64
wheel-musllinux-1-2-cp313-cp313-arm64
wheel-musllinux-1-2-cp313-cp313t-amd64
wheel-musllinux-1-2-cp313-cp313t-arm64
wheel-windows-cp313-cp313-amd64
wheel-windows-cp313-cp313t-amd64

[raulcd]

I have tried to copy using some custom copying on setup.py trying to override bdist_wheel command on this commit:
9566c3b

Similar to how we currently do CopyLicenseSdist but setuptools is pretty opinionated and I find that instead of fighting against it we should just copy the files over before building the wheels and forget about it.

The jobs validate now that the wheels contain both LICENSE.txt and NOTICE.txt so it won't happen again.

[pitrou]

AFAIU, modern build frontends (such as build) build the wheel from the sdist, should we do just that? Either by switching to a modern build frontend, or at worse by unpacking the sdist ourselves :-)

It also ensures that we're shipping consistent contents in both formats, and that we're not missing anything in the sdist.

[raulcd]

@github-actions crossbow submit wheel-manylinux-2-28-cp313-cp313-amd64

[github-actions]

Revision: be696f2

Submitted crossbow builds: ursacomputing/crossbow @ actions-0fbd22f993

Task	Status
wheel-manylinux-2-28-cp313-cp313-amd64

[rok]

Nit:

Suggested change

	license = [
	info.filename for info in f.filelist if re.search(
	r'LICENSE.txt$', info.filename
	)
	]
	assert license, "LICENSE.txt is missing from the wheel."
	notice = [
	info.filename for info in f.filelist if re.search(
	r'NOTICE.txt$', info.filename
	)
	]
	assert notice, "NOTICE.txt is missing from the wheel."
	for filename in ('LICENSE.txt', 'NOTICE.txt'):
	assert any(info.filename.endswith(filename) for info in f.filelist), \
	f"{filename} is missing from the wheel."

[rok]

Just a minor yak shave

[raulcd]

AFAIU, modern build frontends (such as build) build the wheel from the sdist, should we do just that? Either by switching to a modern build frontend, or at worse by unpacking the sdist ourselves :-)

I switched to build on the last commit and we don't seem to be adding the LICENSE.txt and NOTICE.txt files either, that's why it fails: https://github.com/ursacomputing/crossbow/actions/runs/21394020272/job/61587723641

[pitrou]

I switched to build on the last commit and we don't seem to be adding the LICENSE.txt and NOTICE.txt files either, that's why it fails: https://github.com/ursacomputing/crossbow/actions/runs/21394020272/job/61587723641

Yet this seems to be building a sdist, so perhaps something is wrong in our sdist building configuration?

Apparently you can debug this using python -m build --sdist.

Also we'll certainly want to pass --no-isolation to choose our own NumPy version.