GH-49004: [C++][FlightRPC] Run ODBC tests in workflow without cpp_test.sh
#49005
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run test executables once without re-runs and without using test script. This way the segmentation fault is not caught.
|
|
github-actions
bot
added
CI: Extra: C++
alinaliBQ
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
alinaliBQ
commented
Jan 27, 2026
Comment on lines
+440
to
+447
| - name: Run ODBC Unit Tests | ||
| shell: cmd | ||
| run: | | ||
| build\cpp\%ARROW_BUILD_TYPE%\arrow-odbc-spi-impl-test.exe | ||
| - name: Run ODBC Driver Tests | ||
| shell: cmd | ||
| run: | | ||
| build\cpp\%ARROW_BUILD_TYPE%\arrow-flight-sql-odbc-test.exe |
Collaborator
Author
github-actions
bot
added
awaiting committer review
raulcd
reviewed
Jan 28, 2026
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
If I understand correctly this test segfaults if not run in isolation and run as part of ci/scripts/cpp_test.sh?
I am not an expert here but if my understanding is correct I think we should rather investigate why it segfaults instead of hiding it.
| call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll | ||
| # GH-48270 TODO: Resolve segementation fault during Arrow library unload | ||
| # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI | ||
| # GH-48270 TODO: Resolve segementation fault during Arrow library unload, segementation fault is caught with `ci/scripts/cpp_test.sh` |
Member
There was a problem hiding this comment.
Suggested change
| # GH-48270 TODO: Resolve segementation fault during Arrow library unload, segementation fault is caught with `ci/scripts/cpp_test.sh` | |
| # GH-48270 TODO: Resolve segmentation fault during Arrow library unload, segmentation fault is caught with `ci/scripts/cpp_test.sh` |
github-actions
bot
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#49004
If running tests in CI without the
cpp_test.shscript is a no-go, please let me know and I will close the PR.What changes are included in this PR?
arrow-odbc-spi-impl-test.exeandarrow-flight-sql-odbc-test.exein the ODBC job of C++ Extra CI.Are these changes tested?
Yes, in CI
Are there any user-facing changes?
N/A
cpp_test.sh#49004