Skip to content

Conversation

@vishesh92
Copy link
Member

This pull request updates documentation and deployment configuration for the CloudStack Kubernetes Provider. The main focus is on enhancing the README.md with detailed explanations of supported service annotations for LoadBalancer services, clarifying node label assignment logic, and updating the deployment image version.

Documentation improvements:

  • Added a new "Service Annotations" section to README.md describing three supported annotations for LoadBalancer services:

    • cloudstack-load-balancer-proxy-protocol (for enabling HAProxy Proxy Protocol),
    • cloudstack-load-balancer-hostname (for setting a hostname as ingress),
    • cloudstack-load-balancer-source-cidrs (for restricting allowed source CIDRs).
      Each annotation includes type, default, use case, and example usage.
  • Clarified the logic for node region labels in README.md, specifying that the region label uses the region from config if defined, otherwise defaults to the zone.

Deployment update:

  • Updated the container image in deployment.yaml from version v1.1.0 to v1.2.0 for the cloud-controller-manager.

Copilot AI review requested due to automatic review settings December 15, 2025 11:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.05%. Comparing base (1b75921) to head (4427d06).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #91       +/-   ##
===========================================
+ Coverage   17.53%   50.05%   +32.51%     
===========================================
  Files           4        4               
  Lines         975      975               
===========================================
+ Hits          171      488      +317     
+ Misses        800      473      -327     
- Partials        4       14       +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the CloudStack Kubernetes Provider for the v1.2.0 release by updating the deployment image version and significantly enhancing documentation for LoadBalancer service annotations and node labeling behavior.

Key changes:

  • Updated container image from v1.1.0 to v1.2.0 in deployment configuration
  • Added comprehensive documentation for three LoadBalancer service annotations with detailed descriptions, use cases, and examples
  • Clarified the node region label assignment logic to specify it uses config region when defined, otherwise falls back to zone

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
deployment.yaml Updates cloud-controller-manager container image version from v1.1.0 to v1.2.0
README.md Adds "Service Annotations" section documenting cloudstack-load-balancer-proxy-protocol, cloudstack-load-balancer-hostname, and cloudstack-load-balancer-source-cidrs annotations; clarifies region label assignment logic for both legacy and modern Kubernetes label formats

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@DaanHoogland DaanHoogland merged commit 4740dbc into main Dec 16, 2025
7 checks passed
@DaanHoogland DaanHoogland deleted the release-1.2.0 branch December 16, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants