add separate VP component to update VP id and links #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
will enter some description @jbampton ;) |
DaanHoogland
requested review from
Pearl1594 and
Copilot
and removed request for
Pearl1594
There was a problem hiding this comment.
Pull Request Overview
This PR adds a reusable VP (Vice President/PMC Chair) component to display the current PMC chair information with enhanced visual presentation including photo, links, and quote. The change replaces static PMC chair text with a dynamic React component to make yearly updates easier.
- Replace static PMC chair text with a dynamic VP React component
- Update file generation script to output .mdx format and include VP component
- Remove unused blog template file
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/pages/who.mdx | Replace static PMC chair text with VP component import and usage |
| src/components/VP/index.tsx | New React component displaying PMC chair info with photo, social links, and quote |
| source/generate_who.py | Update script to generate .mdx file and include VP component instead of static text |
| blog/2024-10-25-ccc-agenda/index.md~ | Remove unused blog template file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Pearl1594
approved these changes
Sep 26, 2025
Contributor
Pearl1594
left a comment
Pearl1594
left a comment
There was a problem hiding this comment.
lgtm - made some small suggestions, to add some spacing and reduce the size of the logo - just presentational.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a VP component to the who page to advertise the sitting VP with a bit more allure.
Now, only the src/components/VP/index.tsx has to be changed for the yearly term change or the src/pages/who.mdx has be regenerated when new committers/PMC member are admitted.