Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR adds APIs to clone existing offerings - service, system, network, VPC, backup and update certain parameters of the existing offering.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 0% with 459 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.58%. Comparing base (5bf869c) to head (2afc1b7).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../cloud/configuration/ConfigurationManagerImpl.java 0.00% 411 Missing ⚠️
...command/admin/network/CloneNetworkOfferingCmd.java 0.00% 19 Missing ⚠️
...i/command/admin/offering/CloneDiskOfferingCmd.java 0.00% 13 Missing ⚠️
...ommand/admin/offering/CloneServiceOfferingCmd.java 0.00% 13 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12357      +/-   ##
============================================
+ Coverage     17.51%   17.58%   +0.07%     
- Complexity    15585    15666      +81     
============================================
  Files          5914     5918       +4     
  Lines        529867   530426     +559     
  Branches      64722    64808      +86     
============================================
+ Hits          92782    93280     +498     
- Misses       426635   426678      +43     
- Partials      10450    10468      +18     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.65% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant