Fix Linstor shrink QCOW2 volumes

[nvazquez]

Description

This PR fixes shrinking volumes for Linstor storage, as discussed on: #12297

Fixes: #12297

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.23%. Comparing base (750290b) to head (5f75680).
⚠️ Report is 1 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12387      +/-   ##
============================================
- Coverage     16.23%   16.23%   -0.01%     
+ Complexity    13378    13377       -1     
============================================
  Files          5657     5657              
  Lines        498932   498933       +1     
  Branches      60552    60553       +1     
============================================
- Hits          81016    81014       -2     
- Misses       408882   408888       +6     
+ Partials       9034     9031       -3     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.09% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16298

[DaanHoogland]

@slavkap @rp- can you please review and give your blessings ? (@rp- I saw you wanted shrinking not to be allowed for linstor either???)

[slavkap]

code LGTM

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[sureshanaparti]

lgtm

[blueorangutan]

[SF] Trillian test result (tid-15146)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53001 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12387-t15146-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File