Updated protobuf version to 3.25.5, and protobuf & jackson maven dependencies #12389

sureshanaparti · 2026-01-08T10:01:11Z

Description

This PR updates protobuf version to 3.25.5, and protobuf & jackson maven dependencies in KVM hypervisor plugin.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…ndencies

codecov · 2026-01-08T10:12:07Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.23%. Comparing base (750290b) to head (66b7503).

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12389      +/-   ##
============================================
- Coverage     16.23%   16.23%   -0.01%     
+ Complexity    13378    13376       -2     
============================================
  Files          5657     5657              
  Lines        498932   498932              
  Branches      60552    60552              
============================================
- Hits          81016    81003      -13     
- Misses       408882   408901      +19     
+ Partials       9034     9028       -6

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.09% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR updates protobuf to version 3.25.5 and adds explicit Jackson and protobuf dependency declarations to manage transitive dependency versions effectively.

Adds protobuf version property (3.25.5) and dependency management entries to enforce version consistency across the project
Adds explicit Jackson dependencies to the KVM hypervisor plugin to ensure proper library availability
Adds jackson-dataformat-cbor to the utils module

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
pom.xml	Adds protobuf version property (3.25.5) and dependency management for protobuf-java and protobuf-java-util to override older versions pulled by mysql-connector-java
plugins/hypervisors/kvm/pom.xml	Adds explicit Jackson dependencies (core, annotations, databind, datatype-jsr310, module-jaxb-annotations) needed for JSON processing in the KVM plugin
utils/pom.xml	Adds jackson-dataformat-cbor dependency to support CBOR (Concise Binary Object Representation) data format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pom.xml

DaanHoogland

clgtm

DaanHoogland · 2026-01-08T10:25:01Z

this is marked for kvm but it looks like it will need full regression testing for all platforms.

DaanHoogland · 2026-01-08T10:25:17Z

@blueorangutan package

blueorangutan · 2026-01-08T10:26:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-08T11:35:06Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16302

nvazquez · 2026-01-08T11:36:31Z

@blueorangutan test

blueorangutan · 2026-01-08T11:38:05Z

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-01-09T02:21:29Z

[SF] Trillian test result (tid-15148)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50068 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12389-t15148-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2026-01-09T08:49:50Z

@blueorangutan test matrix

blueorangutan · 2026-01-09T08:52:09Z

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

nvazquez

LGTM

blueorangutan · 2026-01-10T00:45:43Z

[SF] Trillian test result (tid-15152)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53982 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12389-t15152-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2026-01-10T01:31:08Z

[SF] Trillian test result (tid-15153)
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 57128 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12389-t15153-kvm-ubuntu22.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2026-01-10T02:54:21Z

[SF] Trillian test result (tid-15154)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 62000 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12389-t15154-vmware-70u3.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_deploy_more_vms_than_limit_allows	`Error`	140.68	test_deploy_vms_in_parallel.py

blueorangutan · 2026-01-10T06:37:41Z

[SF] Trillian test result (tid-15155)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 76001 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12389-t15155-xcpng82.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	15.33	test_primary_storage.py
test_01_primary_storage_iscsi	`Error`	0.14	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.13	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.22	test_primary_storage.py
test_02_list_snapshots_with_removed_data_store	`Error`	12.51	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	12.51	test_snapshots.py
test_01_deploy_vm_on_specific_host	`Error`	0.06	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.08	test_vm_deployment_planner.py
test_08_migrate_vm	`Error`	0.05	test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success	`Error`	0.17	test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure	`Error`	0.19	test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success	`Error`	0.16	test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure	`Error`	0.19	test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success	`Error`	0.14	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Error`	0.17	test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags	`Error`	0.14	test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags	`Error`	3.38	test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success	`Error`	0.15	test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success	`Error`	5.45	test_vm_strict_host_tags.py
test_05_deploy_vm_on_specific_host_with_strict_tags_failure	`Failure`	0.16	test_vm_strict_host_tags.py

Updated protobuf version to 3.25.5, and protobuf & jackson maven depe…

66b7503

…ndencies

boring-cyborg bot added component:build component:kvm labels Jan 8, 2026

sureshanaparti requested review from abh1sar, Copilot and nvazquez January 8, 2026 10:01

sureshanaparti added this to the 4.20.3 milestone Jan 8, 2026

Copilot started reviewing on behalf of sureshanaparti January 8, 2026 10:09 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

pom.xml Show resolved Hide resolved

DaanHoogland approved these changes Jan 8, 2026

View reviewed changes

DaanHoogland added the status:needs-testing label Jan 8, 2026

nvazquez approved these changes Jan 9, 2026

View reviewed changes

Updated protobuf version to 3.25.5, and protobuf & jackson maven dependencies #12389

Are you sure you want to change the base?

Updated protobuf version to 3.25.5, and protobuf & jackson maven dependencies #12389

Uh oh!

Conversation

sureshanaparti commented Jan 8, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jan 8, 2026

Uh oh!

DaanHoogland commented Jan 8, 2026

Uh oh!

blueorangutan commented Jan 8, 2026

Uh oh!

blueorangutan commented Jan 8, 2026

Uh oh!

nvazquez commented Jan 8, 2026

Uh oh!

blueorangutan commented Jan 8, 2026

Uh oh!

blueorangutan commented Jan 9, 2026

Uh oh!

DaanHoogland commented Jan 9, 2026

Uh oh!

blueorangutan commented Jan 9, 2026

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 10, 2026

Uh oh!

blueorangutan commented Jan 10, 2026

Uh oh!

blueorangutan commented Jan 10, 2026

Uh oh!

blueorangutan commented Jan 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 8, 2026 •

edited

Loading