-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[WIP] Add vm instance id to volume usage record #9217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add vm instance id to volume usage record #9217
Conversation
0ca37b4 to
92e72f1
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9217 +/- ##
============================================
+ Coverage 14.96% 15.32% +0.35%
- Complexity 11002 11652 +650
============================================
Files 5373 5452 +79
Lines 469309 476576 +7267
Branches 58607 58211 -396
============================================
+ Hits 70231 73014 +2783
- Misses 391304 395494 +4190
- Partials 7774 8068 +294
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rohityadavcloud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - didn't test it; perhaps this could have some test added (Marvin test?)
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
Fix is addressed in #11531, no further work needed. Closing this. |
Description
This PR adds vm instance id to volume usage record, addresses #7399
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?