-
Notifications
You must be signed in to change notification settings - Fork 272
feat: Support left expression #3206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support left expression #3206
Conversation
|
@Shekharrajak can you run |
andygrove
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI. Thanks @Shekharrajak
|
@Shekharrajak could you take a look at the CI failures? |
Updated configs.md now the checks should succeed. Please trigger the workflow |
Moved Left.enabled config entry to come after LastDay.enabled to maintain alphabetical ordering in the expression configs table.
|
Looks like order was not correct last time. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3206 +/- ##
============================================
+ Coverage 56.12% 59.99% +3.86%
- Complexity 976 1418 +442
============================================
Files 119 170 +51
Lines 11743 15793 +4050
Branches 2251 2610 +359
============================================
+ Hits 6591 9475 +2884
- Misses 4012 4998 +986
- Partials 1140 1320 +180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Checks are looking fine now. |
|
Thanks again @Shekharrajak |
Closes #3181
Rationale for this change
Enable native execution for Spark's
LEFT(str, len)function to improve query performance by avoiding JVM fallback.What changes are included in this PR?
CometLeftserializer that transformsLEFT(str, len)toSubstring(str, 1, len)protobufLeftexpression inQueryPlanSerdestring expressions mapHow are these changes tested?
Added 4 test suites in
CometExpressionSuite:SUBSTRING(str, 1, len)