Skip to content

Conversation

@kazantsev-maksim
Copy link
Contributor

@kazantsev-maksim kazantsev-maksim commented Jan 25, 2026

Which issue does this PR close?

N/A

Rationale for this change

What changes are included in this PR?

  1. Added native Comet support for Spark's elt function
  2. Uses the SparkElt implementation from the datafusion-spark crate

How are these changes tested?

  1. Added unit test in CometStringExpressionSuite.scala
  2. Added new benchmark test in CometStringExpressionBenchmark.scala

Microbenchmark result:

elt

object CometElt extends CometScalarFunction[Elt]("elt") {

override def getSupportLevel(expr: Elt): SupportLevel = {
if (expr.failOnError) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant