PostgreSQL: Support PRIMARY KEY/UNIQUE USING INDEX#2213
Open
guan404ming wants to merge 2 commits intoapache:mainfrom
Open
PostgreSQL: Support PRIMARY KEY/UNIQUE USING INDEX#2213guan404ming wants to merge 2 commits intoapache:mainfrom
guan404ming wants to merge 2 commits intoapache:mainfrom
Conversation
Signed-off-by: Guan-Ming Chiu <guanmingchiu@gmail.com>
guan404ming
force-pushed
the
pg-primary-key-using-index
branch
from
3cdaa92 to
91a677f
Compare
iffyio
reviewed
Feb 18, 2026
Comment on lines
9396
to
9408
| if self.parse_keywords(&[Keyword::USING, Keyword::INDEX]) { | ||
| let index_name = self.parse_identifier()?; | ||
| let characteristics = self.parse_constraint_characteristics()?; | ||
| return Ok(Some( | ||
| ConstraintUsingIndex { | ||
| name, | ||
| is_primary_key: true, | ||
| index_name, | ||
| characteristics, | ||
| } | ||
| .into(), | ||
| )); | ||
| } |
Contributor
There was a problem hiding this comment.
can we pull this out into a e.g. parse_constraint_using_index() function so that it can be reused across both cases?
Also repr wise, I think it would be clearer to have both cases as unique variants on the TableConstraint enum vs using the is_primary_key bool to differentiate. i.e.
TableConstraint::UniqueUsingIndex(ConstraintUsingIndex)
TableConstraint::PrimaryKeyUsingIndex(ConstraintUsingIndex)
Member
Author
There was a problem hiding this comment.
Yes, thanks for the nice suggestions. I just updated with
- Split enum variant:
TableConstraint::ConstraintUsingIndexintoPrimaryKeyUsingIndexandUniqueUsingIndex, removing theis_primary_key boolfrom the struct. - Extracted helper: Created
parse_constraint_using_index()to deduplicate the parsing logic used by bothUNIQUE USING INDEXandPRIMARY KEY USING INDEX.
guan404ming
force-pushed
the
pg-primary-key-using-index
branch
from
2f4982a to
483ddeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PostgreSQL allows promoting an existing unique index to a PRIMARY KEY or UNIQUE table constraint via ALTER TABLE, which was
not supported by the parser.
How