fix: add parentheses to nested binary expression Display #19916
+552
−482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #16054
Rationale for this change
Binary expressions like
(1+2)*3were displayed incorrectly asInt64(1) + Int64(2) * Int64(3)without parentheses, which is misleading because it doesn't preserve the operator precedence from the original expression.What changes are included in this PR?
Displayimplementation forBinaryExprto always wrap nested binary expressions in parenthesesSchemaDisplayandSqlDisplaywrappersHow are these changes tested?
test_binary_expr_display_with_parenthesescovering:(1+2)*3(a OR b) AND cAre these changes safe?
Yes. This follows DuckDB's approach of always adding parentheses around nested binary expressions, which was discussed and approved in the issue comments.
Example
Before:
After: