feat: Support planning subqueries with OuterReferenceColumn belongs to non-adjacent outer relations Cleanup #19930
+270
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
mkleen
changed the title
mkleen
commented
Jan 21, 2026
| Projection: l.a, l.b, l.c, l.d, l.e | ||
| SubqueryAlias: l | ||
| Projection: lineitem.l_item_id AS a, lineitem.l_description AS b, lineitem.price AS c | ||
| Projection: lineitem.l_orderkey AS a, lineitem.l_item_id AS b, lineitem.l_description AS c, lineitem.l_extendedprice AS d, lineitem.price AS e |
Contributor
Author
There was a problem hiding this comment.
This is because the lineitem table is extended now.
mkleen
commented
Jan 21, 2026
| "o1.o_custkey".to_string(), | ||
| "o1.o_orderstatus".to_string(), | ||
| "o1.customer_id".to_string(), | ||
| "o1.o_totalprice".to_string(), |
Contributor
Author
There was a problem hiding this comment.
This is because the order table is extended now.
mkleen
commented
Jan 21, 2026
| assert_snapshot!( | ||
| err.strip_backtrace(), | ||
| @"Error during planning: Source table contains 3 columns but only 2 names given as column alias" | ||
| @"Error during planning: Source table contains 5 columns but only 2 names given as column alias" |
Contributor
Author
There was a problem hiding this comment.
This is because the lineitem table is extended now.
mkleen
commented
Jan 21, 2026
| ])), | ||
| "orders" => Ok(Schema::new(vec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Cleaned-up version of #18806 according to #18806 (review) with:
Removed
outer_queries_schemafrom PlannerContextPlanning logic only (optimizer modifications removed)
sql logic tests moved to sql_integration.rs
Closes Supporting planning (binding) Nested correlated subquery error with a depth exceeding 1 #19816
Rationale for this change
See #18806
What changes are included in this PR?
See #18806
Are these changes tested?
Yes
Are there any user-facing changes?
outer_queries_schemais removed from PlannerContext.