Enhance visualization with display_name tag support #1445
Conversation
This update introduces the tag for nodes in graph visualizations, allowing for human-readable labels while maintaining valid Python identifiers as function names. The changes include: - Documentation updates to explain the usage of in visualizations. - Modifications to the graph creation logic to utilize when available. - New tests to ensure is correctly applied in visualizations and that HTML characters are properly escaped. - Example functions demonstrating the use of in a new resource file. This feature improves the readability of visualizations for stakeholders while keeping the codebase Pythonic.
…special characters are properly escaped in the label.
This update improves the handling of the display_name tag in graph visualizations by adding support for cases where display_name is a list. The first element of the list will now be used as the display name. Additionally, new tests have been added to verify this functionality, ensuring that the correct display names are rendered in the graph output. This enhancement contributes to better readability and usability of visualizations.
|
Greetings, @skrawcz I was attempting to assign you as a reviewer, but I believe I don't have the appropriate permissions. |
skrawcz
left a comment
skrawcz
left a comment
There was a problem hiding this comment.
Looking good -- will let CI run and see if things pass -- otherwise one small nit with respect to imports in the test, if you could just import it at the top level please.
|
The unit test errors are unrelated -- mind showing evidence yours passes? Unit test errors are:
|
@skrawcz
|
|
Happy to help with other issues once this ticket is closed! If there are any documented open issues, I'd be glad to take them on. |
|
One more thing - the sphinx build broke with:
|
|
@Exudev almost there -- seems like there is a linting issue :/ mind installing the pre-commit hooks and running them? It should fix it since it was ruff that complained. |
|
@skrawcz done :D |
skrawcz
left a comment
skrawcz
left a comment
There was a problem hiding this comment.
LGTM thanks!
We can fix the unrelated unit tests in another PR...
|
Of course anything, just assign me the issues and ill be on it. |
2 participants
This update introduces the tag for nodes in graph visualizations, allowing for human-readable labels while maintaining valid Python identifiers as function names. The changes include:
Issue