Skip to content

Comments

HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC…#7720

Open
liuxiaocs7 wants to merge 2 commits intoapache:masterfrom
liuxiaocs7:HBASE-29874
Open

HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC…#7720
liuxiaocs7 wants to merge 2 commits intoapache:masterfrom
liuxiaocs7:HBASE-29874

Conversation

@liuxiaocs7
Copy link
Contributor

…ellTTLExpired

see: HBASE-29874

@liuxiaocs7 liuxiaocs7 force-pushed the HBASE-29874 branch 7 times, most recently from 157a9a7 to b5eebb4 Compare February 15, 2026 18:34
@liuxiaocs7
Copy link
Contributor Author

Hi, @Apache9 and @junegunn, what do you think of this change, failed uts seems unrelated, thanks!

@Apache9
Copy link
Contributor

Apache9 commented Feb 24, 2026

09cd3d7

The method is added in this commit, seems the parameter is not used from beginning...

Copy link
Member

@junegunn junegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Safe to remove.

Copy link
Contributor

@vaijosh vaijosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Feb 24, 2026

Failed Tests only includes Flakes error type UT(https://github.com/apache/hbase/actions/runs/22041463681?pr=7720)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants