[Expr Serde] [PR 1/X] basic plumbing for serde support for expressions #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evindj
changed the title
evindj
changed the title
wgtmac
reviewed
Jan 27, 2026
| #include "iceberg/iceberg_export.h" | ||
| #include "iceberg/result.h" | ||
|
|
||
| /// \file iceberg/expression/json_internal.h |
| expression/expression.cc | ||
| expression/expressions.cc | ||
| expression/inclusive_metrics_evaluator.cc | ||
| expression/json_serde.cc |
Member
There was a problem hiding this comment.
We also need to update meson.build for any new file.
| ICEBERG_EXPORT nlohmann::json ToJson(const Model& model); | ||
|
|
||
| /// \note Don't forget to add `ICEBERG_DEFINE_FROM_JSON` to the end of | ||
| /// `json_internal.cc` to define the `FromJson` function for the model. |
| add_iceberg_test(expression_test | ||
| SOURCES | ||
| aggregate_test.cc | ||
| expression_json_test.cc |
src/iceberg/expression/json_serde.cc
Outdated
| Result<std::shared_ptr<Expression>> ExpressionFromJson(const nlohmann::json& json) { | ||
| // Handle boolean | ||
| if (json.is_boolean()) { | ||
| return json.get<bool>() ? std::static_pointer_cast<Expression>(True::Instance()) |
| EXPECT_EQ(result.value()->op(), Expression::Operation::kTrue); | ||
| } | ||
|
|
||
| TEST_F(ExpressionJsonTest, FalseExpression) { |
Member
There was a problem hiding this comment.
These two cases share a lot of similarities. Can we use a single test?
added 2 commits
January 27, 2026 06:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first PR aimed a addressing #331
Because doing it in one go will be more error prone and will make review harder, I am splitting the change across several PR.
This first one covers:
Test
~/Documents/my_iceberg/iceberg-cpp bool_expressio_serde ./build/src/iceberg/test/expression_test --gtest_filter="ExpressionJson*" ✔ 1297 13:53:47
Running main() from gmock_main.cc
Note: Google Test filter = ExpressionJson*
[==========] Running 2 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 2 tests from ExpressionJsonTest
[ RUN ] ExpressionJsonTest.TrueExpression
[ OK ] ExpressionJsonTest.TrueExpression (0 ms)
[ RUN ] ExpressionJsonTest.FalseExpression
[ OK ] ExpressionJsonTest.FalseExpression (0 ms)
[----------] 2 tests from ExpressionJsonTest (0 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test suite ran. (0 ms total)
[ PASSED ] 2 tests.
idjiofack@Innocents-MacBook-Pro-2 ~/Documents/my_iceberg/iceberg-cpp bool_expressio_serde