IGNITE-27776 Simplify custom messages hierarchy#12708
Merged
shishkovilja merged 7 commits intoapache:masterfrom Feb 24, 2026
Merged
IGNITE-27776 Simplify custom messages hierarchy#12708shishkovilja merged 7 commits intoapache:masterfrom
shishkovilja merged 7 commits intoapache:masterfrom
Conversation
shishkovilja
force-pushed
the
ignite-27776
branch
from
848a00d to
ff4d3f1
Compare
Vladsz83
reviewed
Feb 16, 2026
modules/core/src/test/java/org/apache/ignite/testframework/GridTestUtils.java
Outdated
Show resolved
Hide resolved
| */ | ||
| @Nullable public DiscoverySpiCustomMessage ackMessage(); | ||
| @Deprecated | ||
| public abstract class DiscoverySpiCustomMessage implements DiscoveryCustomMessage { |
Contributor
There was a problem hiding this comment.
Can we set the defaults for isMutable(), ackMessage(), createDiscoCache() in DiscoveryCustomMessage? WDYT? There is a lot of overrided return null/false. Other ticket?
Contributor
Author
There was a problem hiding this comment.
I think it sounds reasonable. Let's implement it in a tiket: https://issues.apache.org/jira/browse/IGNITE-27778
...s/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ClientImpl.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/spi/discovery/DiscoveryNotification.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/spi/discovery/DiscoverySpiCustomMessage.java
Outdated
Show resolved
Hide resolved
anton-vinogradov
approved these changes
Feb 19, 2026
shishkovilja
force-pushed
the
ignite-27776
branch
from
ff4d3f1 to
c52a7a4
Compare
shishkovilja
force-pushed
the
ignite-27776
branch
from
c52a7a4 to
71809df
Compare
# Conflicts: # modules/zookeeper/src/test/java/org/apache/ignite/spi/discovery/zk/ZookeeperDiscoverySpiTestConfigurator.java
|
Vladsz83
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.