-
Notifications
You must be signed in to change notification settings - Fork 917
Update javac package list in APTUtils #8931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@lahodaj could you check if this update is ok? I believe that currently some classes may be loaded using the wrong CL since the list misses some packages. |
216db69 to
702d082
Compare
java/java.source.base/src/org/netbeans/modules/java/source/indexing/APTUtils.java
Show resolved
Hide resolved
702d082 to
cc0828e
Compare
removed - com.sun.javadoc - com.sun.tools.javadoc - com.sun.tools.hc added - com.sun.tools.doclint - com.sun.tools.javap
|
gong to rebase this for a fresh dev build |
cc0828e to
0fa3d35
Compare
| OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/nbjavac/api/Bundle.properties | ||
| OpenIDE-Module-Specification-Version: 21.9 | ||
| OpenIDE-Module-Hide-Classpath-Packages: com.sun.javadoc.**, com.sun.source.**, javax.annotation.processing.**, javax.lang.model.**, javax.tools.**, com.sun.tools.javac.** com.sun.tools.javac.**, com.sun.tools.javadoc.**, com.sun.tools.javap.**, com.sun.tools.classfile.**, com.sun.tools.doclint.** | ||
| OpenIDE-Module-Hide-Classpath-Packages: com.sun.source.**, javax.annotation.processing.**, javax.lang.model.**, javax.tools.**, com.sun.tools.javac.**, com.sun.tools.javap.**, com.sun.tools.classfile.**, com.sun.tools.doclint.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth noting that a coma was missing in this section: com.sun.tools.javac.** com.sun.tools.javac.**,
Saw that list while going through heap dumps and looking through GC roots. Looks important.
Not sure if
org.netbeans.lib.nbjavacneeds to be on it too or only the original javac packages.removed
com.sun.javadoccom.sun.tools.javadoccom.sun.tools.hcadded
com.sun.tools.doclintcom.sun.tools.javap