Skip to content

signals: fix dependency issues when signals are all disabled #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wangchdo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

signals: fix dependency issues when signals are all disabled #3333

wangchdo wants to merge 1 commit into from

Conversation

@wangchdo
Copy link
Contributor

@wangchdo wangchdo commented Jan 15, 2026

Fix build and runtime issues when signals all disabled.

Summary

This PR fixes dependency issues when signals are all disabled

Impact

Fix dependency issues when signals are all disabled, no impact to any existing functions

Testing

ostest passed on rv-virt:smp64

disable all signals

image

ostest passed log

NuttShell (NSH)
nsh> 
nsh> uname -a
NuttX 0.0.0 02cfe5cf75-dirty Jan 15 2026 16:37:47 risc-v rv-virt
nsh> 
nsh> ostest

(...)

smp_call_test: Test start
smp_call_test: Call cpu 0, nowait
smp_call_test: Call cpu 0, wait
smp_call_test: Call cpu 1, nowait
smp_call_test: Call cpu 1, wait
smp_call_test: Call cpu 2, nowait
smp_call_test: Call cpu 2, wait
smp_call_test: Call cpu 3, nowait
smp_call_test: Call cpu 3, wait
smp_call_test: Call cpu 4, nowait
smp_call_test: Call cpu 4, wait
smp_call_test: Call cpu 5, nowait
smp_call_test: Call cpu 5, wait
smp_call_test: Call cpu 6, nowait
smp_call_test: Call cpu 6, wait
smp_call_test: Call cpu 7, nowait
smp_call_test: Call cpu 7, wait
smp_call_test: Call multi cpu, nowait
smp_call_test: Call in interrupt, wait
smp_call_test: Call multi cpu, wait
smp_call_test: Test success

Final memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     1fc2d20  1fc2d20
ordblks         1        7
mxordblk  1fb7c78  1f709c0
uordblks     b0a8    16278
fordblks  1fb7c78  1facaa8
user_main: Exiting
ostest_main: Exiting with status 0
nsh>

@wangchdo wangchdo force-pushed the enable_disable_all_signals branch 5 times, most recently from e1cf0b0 to 0625200 Compare January 15, 2026 12:11
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch from 0625200 to cf6a657 Compare January 16, 2026 00:58
@wangchdo wangchdo mentioned this pull request Jan 16, 2026
Open
xiaoxiang781216
xiaoxiang781216 reviewed Jan 16, 2026
View reviewed changes
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch from cf6a657 to e3804fa Compare January 16, 2026 02:02
xiaoxiang781216
xiaoxiang781216 reviewed Jan 16, 2026
View reviewed changes
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch 2 times, most recently from af94348 to 0cc5a9a Compare January 16, 2026 04:04
xiaoxiang781216
xiaoxiang781216 reviewed Jan 16, 2026
View reviewed changes
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch 5 times, most recently from 66096e1 to 62f6066 Compare January 16, 2026 09:21
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch from 62f6066 to 8610764 Compare January 16, 2026 09:52
xiaoxiang781216
xiaoxiang781216 reviewed Jan 16, 2026
View reviewed changes
canutils/candump/CMakeLists.txt Outdated
# ##############################################################################

if(CONFIG_CANUTILS_CANDUMP)
if(CONFIG_CANUTILS_CANDUMP AND CONFIG_ENABLE_ALL_SIGNALS)
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add depends on ENABLE_ALL_SIGNALS on Kconfig directly

Copy link
Contributor Author

@wangchdo wangchdo Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

canutils/candump/Make.defs Outdated
############################################################################/

ifneq ($(CONFIG_CANUTILS_CANDUMP),)
ifneq ($(CONFIG_ENABLE_ALL_SIGNALS),)
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

@wangchdo wangchdo Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

examples/i2sloop/Make.defs Outdated
############################################################################

ifneq ($(CONFIG_EXAMPLES_I2SLOOP),)
ifneq ($(CONFIG_ENABLE_ALL_SIGNALS),)
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

@wangchdo wangchdo Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

testing/drivers/nand_sim/Make.defs Outdated
############################################################################

ifneq ($(CONFIG_TESTING_NAND_SIM),)
ifneq ($(CONFIG_ENABLE_ALL_SIGNALS),)
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to Kconfig

Copy link
Contributor Author

@wangchdo wangchdo Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

testing/drivers/nand_sim/CMakeLists.txt Outdated
# ##############################################################################

if(CONFIG_TESTING_NAND_SIM)
if(CONFIG_TESTING_NAND_SIM AND CONFIG_ENABLE_ALL_SIGNALS)
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

@wangchdo wangchdo Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

system/sensortest/Make.defs Outdated
############################################################################

ifneq ($(CONFIG_SYSTEM_SENSORTEST),)
ifneq ($(CONFIG_ENABLE_ALL_SIGNALS),)
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

@wangchdo wangchdo Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

examples/zerocross/Make.defs Outdated
############################################################################

ifneq ($(CONFIG_EXAMPLES_ZEROCROSS),)
ifneq ($(CONFIG_ENABLE_ALL_SIGNALS),)
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to Kconfig

Copy link
Contributor Author

@wangchdo wangchdo Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

examples/zerocross/CMakeLists.txt Outdated
# ##############################################################################

if(CONFIG_EXAMPLES_ZEROCROSS)
if(CONFIG_EXAMPLES_ZEROCROSS AND CONFIG_ENABLE_ALL_SIGNALS)
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

@wangchdo wangchdo Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

examples/xedge_demo/Make.defs Outdated
############################################################################

ifneq ($(CONFIG_EXAMPLES_XEDGE_DEMO),)
ifneq ($(CONFIG_ENABLE_ALL_SIGNALS),)
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Copy link
Contributor Author

@wangchdo wangchdo Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

examples/oneshot/Make.defs Outdated
############################################################################

ifneq ($(CONFIG_EXAMPLES_ONESHOT),)
ifneq ($(CONFIG_ENABLE_ALL_SIGNALS),)
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to Kconfig

Copy link
Contributor Author

@wangchdo wangchdo Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@wangchdo
signals: fix build and runtime issues when signals all isabled
f6bf01a 
  Fix build and runtime issues when signals all disabled.

Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch from 8610764 to f6bf01a Compare January 16, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Area: CAN Area: Examples Area: NSH Area: System Area: Testing Area: Wireless Size: M Size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wangchdo @xiaoxiang781216