HDDS-12802. Avoid using reflection in SimpleStriped#9814
Open
echonesis wants to merge 2 commits intoapache:masterfrom
Open
HDDS-12802. Avoid using reflection in SimpleStriped#9814echonesis wants to merge 2 commits intoapache:masterfrom
echonesis wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thanks @echonesis for the patch. |
Contributor
Author
Thanks @adoroszlai for mentioning. |
adoroszlai
reviewed
Feb 25, 2026
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @echonesis for updating the patch. I think we can replace calls of SimpleStriped.custom with Striped.custom, and completely remove both SimpleStriped.custom and TestSimpleStriped.testCustomStripes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR eliminates the reflection-based workaround in
SimpleStripedby using native public method directly.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12802
How was this patch tested?
GitHub Actions CI: https://github.com/echonesis/ozone/actions/runs/22379059258