HDDS-14721. Make OM bootstrap implementation configurable.#9830
Draft
sadanand48 wants to merge 4 commits intoapache:masterfrom
Draft
HDDS-14721. Make OM bootstrap implementation configurable.#9830sadanand48 wants to merge 4 commits intoapache:masterfrom
sadanand48 wants to merge 4 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Feb 25, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sadanand48 for the patch.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMBootstrapV2.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMBootstrap.java
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMBootstrap.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMBootstrap.java
Show resolved
Hide resolved
yandrey321
reviewed
Feb 26, 2026
| Files.delete(sourcePath); | ||
| } | ||
| } catch (IOException e) { | ||
| LOG.warn("Failed to delete source file {}: {}", sourcePath, e.getMessage()); |
There was a problem hiding this comment.
are we going to retry after the next start or files would stay there forever?
yandrey321
reviewed
Feb 26, 2026
| LOG.info("Creating om.db and moving {} active DB files for v1 format", toMove.size()); | ||
| Files.createDirectories(omDbDir); | ||
| for (Path source : toMove) { | ||
| Path target = omDbDir.resolve(source.getFileName()); |
There was a problem hiding this comment.
how do we handle exception when something cannot be moved? or resolved
yandrey321
reviewed
Feb 26, 2026
| OZONE_OM_RATIS_SNAPSHOT_MAX_TOTAL_SST_SIZE_DEFAULT = 10737418240L; | ||
|
|
||
| public static final String OZONE_OM_DB_CHECKPOINT_USE_V2_KEY | ||
| = "ozone.om.db.checkpoint.use.v2"; |
There was a problem hiding this comment.
v2 is not descriptive name, it's not clear what is the difference between v1 and v2.
yandrey321
suggested changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
With the recent bootstrap V2 impl done as part of HDDS-12984, make the impl controllable via a config.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14721
How was this patch tested?
unit and integration tests