HDDS-14725. Display retry messages in cli when scm's are unavailable#9834
Open
Gargi-jais11 wants to merge 1 commit intoapache:masterfrom
Open
HDDS-14725. Display retry messages in cli when scm's are unavailable#9834Gargi-jais11 wants to merge 1 commit intoapache:masterfrom
Gargi-jais11 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@adoroszlai @ChenSammi Please review the patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When all SCM instances are down or unreachable, CLI commands that query SCM (e.g. ozone admin datanode list, decommission, diskbalancer, usageinfo, maintenance, etc.) appear to hang for up to ~10–15 minutes before failing.
Current behaviour with scm's down in ha : Happens for all commands querying scm
Proposed fix:
Make Retry logs to be shown up in the cli output to
stderrinSCMFailoverProxyProviderBase.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14725
How was this patch tested?
Added integration test in
TestFailoverWithScmHAfor commands querying scm.Tested locally: