HDDS-14671. Remove healthy_readonly state from SCM#9836
HDDS-14671. Remove healthy_readonly state from SCM#9836sodonnel wants to merge 9 commits intoapache:HDDS-14496-zdufrom
Conversation
sodonnel
changed the title
github-actions
bot
added
the
zdu
Gargi-jais11
left a comment
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @sodonnel for the patch.
Few more places it needs updation like comment changes.
| // First set the node to decommissioned, then run through all op states in | ||
| // order and ensure the healthy_to_healthy_readonly event gets fired | ||
| nsm.setNodeOperationalState(dn, | ||
| HddsProtos.NodeOperationalState.DECOMMISSIONED); | ||
| for (HddsProtos.NodeOperationalState s : | ||
| HddsProtos.NodeOperationalState.values()) { | ||
| eventPublisher.clearEvents(); | ||
| nsm.setNodeOperationalState(dn, s); | ||
| assertEquals(SCMEvents.HEALTHY_READONLY_TO_HEALTHY_NODE, eventPublisher.getLastEvent()); | ||
| assertEquals(SCMEvents.UNHEALTHY_TO_HEALTHY_NODE, eventPublisher.getLastEvent()); |
There was a problem hiding this comment.
Need to update the comment as well to:
order and ensure the unhealthy_to_healthy event gets fired
| // All datanodes on the SCM should have moved to HEALTHY-READONLY state. | ||
| TestHddsUpgradeUtils.testDataNodesStateOnSCM( | ||
| cluster.getStorageContainerManagersList(), NUM_DATA_NODES, | ||
| HEALTHY_READONLY, HEALTHY); | ||
| TestHddsUpgradeUtils.testDataNodesStateOnSCM(cluster.getStorageContainerManagersList(), NUM_DATA_NODES, HEALTHY); |
There was a problem hiding this comment.
Please update the comment above to:
All datanodes on the SCM should have moved to HEALTHY state.
There was a problem hiding this comment.
Please update the comment here as well.
There was a problem hiding this comment.
Please update this comment as well.
|
I think the Dropdown and query still include "healthy_readonly" in Grafana dashboard of Overall-Metrics. This should be removed since the state is deprecated. |
I just didn't know that was there. I have removed the metrics now. It is better to take them away I think. I have addressed the other comments too. |
Thank you. It happens while removing code we don't know about code in few places |
2 participants
What changes were proposed in this pull request?
Healthy_Readonly was added only for the upgrade flow, and it is no longer needed, so we should remove it.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14671
How was this patch tested?
Existing tests, some of which were modified to reflect the new behavior.