HDDS-14729. Address followup items in HDDS-14646#9838
Open
sodonnel wants to merge 3 commits intoapache:HDDS-14496-zdufrom
Open
HDDS-14729. Address followup items in HDDS-14646#9838sodonnel wants to merge 3 commits intoapache:HDDS-14496-zdufrom
sodonnel wants to merge 3 commits intoapache:HDDS-14496-zdufrom
Conversation
github-actions
bot
added
the
zdu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Address the left over comments from #9779 -
Remove unused methods:
SCMUpgradeFinalizationContext#getConfiguration
SCMUpgradeFinalizationContext#getLayoutVersionManager
SCMUpgradeFinalizationContext#getPipelineManager
Nits in TestHddsUpgradeUtils.java
Note that the change to
dsm.getContainer().getContainerSet().containerCount();cannot be made, as getContainerSet() in this instance doesn't return a set, but aniterator()and there is no count method available.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14729
How was this patch tested?
Existing tests.