PHOENIX-7748 Empty column cell is not returned when scan has both EmptyColumnOnlyFilter and DistinctPrefixFilter #2353
+113
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyColumnOnlyFilter and DistinctPrefixFilter
tkhurana
force-pushed
the
PHOENIX-7748
branch
from
52444e2 to
98b300b
Compare
kadirozde
reviewed
Jan 23, 2026
|
|
||
| @Override | ||
| public void filterRowCells(List<Cell> kvs) throws IOException { | ||
| if (kvs.size() > 1) { |
Contributor
There was a problem hiding this comment.
We expect that the list size is either 1 or 2. If it is more than 2, we should catch it. I suggest we should log an error for that.
| // since the empty column cell could have been excluded by another filter like the | ||
| // DistinctPrefixFilter. | ||
| Cell cell = kvs.get(0); | ||
| if (found && !ScanUtil.isEmptyColumn(cell, emptyCF, emptyCQ)) { |
Contributor
There was a problem hiding this comment.
Does this really happen in ITs or is it just a defensive coding?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.