removes obsolete Node v14 from CI testing#8647
Closed
DougReeder wants to merge 2 commits intoapache:masterfrom
Closed
removes obsolete Node v14 from CI testing#8647DougReeder wants to merge 2 commits intoapache:masterfrom
DougReeder wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
I expect, Node 18 should work fine. |
Contributor
Author
|
If the tests are just flaky under Node 18 Debian, it's probably best to investigate before adding 18 to the CI. IMNSHO, tests failing in CI should mean something. |
Contributor
|
@DougReeder the test-suite is flaky in every node version... |
alxndrsn
requested changes
Sep 29, 2023
Contributor
alxndrsn
left a comment
There was a problem hiding this comment.
Sadly this change breaks tests in new ways, e.g.
pouchdb-server (firefox, TYPE=find PLUGINS=pouchdb-find ADAPTERS=http npm test)
1) test.ltgt.js $gt on nested field:
expected 100 to equal 101
+ expected - actual
-100
+101
I think these should be addressed before merging.
Contributor
|
This has been implemented in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests pass under Node 18 and 20 on MacOS 13, but under Node 18 on Debian, there is one failure, so adding Node 18 and 20 to CI will have to wait for a future PR.
test.issue3179.js-local-http
✓ #3179 conflicts synced, non-live replication (178ms)
1) #3179 conflicts synced, non-live sync
924 passing (46s)
17 pending
1 failing
TypeError: Cannot read properties of undefined (reading '0')
at tests/integration/test.issue3179.js:85:54
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)