-
Notifications
You must be signed in to change notification settings - Fork 107
fix: pin packaging dep to 25 #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kezhenxu94
commented
Jan 12, 2026
- If this pull request closes/resolves/fixes an existing issue, replace the issue url. Closes:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to address an issue by pinning the packaging library dependency to version 25.0. However, the PR lacks documentation about what specific problem this change is intended to fix.
Changes:
- Pin the
packagingdependency from wildcard ('*') to exact version '25.0'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pyproject.toml
Outdated
| grpcio = '*' | ||
| grpcio-tools = '*' | ||
| packaging = '*' | ||
| packaging = '25.0' |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description lacks critical information about why the packaging dependency needs to be pinned to version 25.0. Without context about what issue this fixes or why this specific version is required, it's difficult to validate whether this is the correct approach.
Additionally, the poetry.lock file currently shows packaging version 24.2 is in use. If version 25.0 doesn't exist yet or if there are compatibility concerns, this change could break the build. Please verify that:
- Version 25.0 of the packaging library actually exists and is available on PyPI
- It's compatible with the Python version constraints (>=3.8, <=3.13)
- There's a documented reason for this specific version pin (e.g., a bug fix, breaking change in a newer version, etc.)
| packaging = '25.0' | |
| packaging = '24.2' |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>