[SPARK-55279][SQL][FOLLOW-UP] Add sketch_funcs and Datasketch grouping for SQL functions #54231
Conversation
…g for SQL functions
|
@allisonwang-db @dongjoon-hyun @yaooqinn Hi all, this is a quick followup to the work done here: #54061 |
HyukjinKwon
changed the title
| * Merges two binary representations of Datasketches HllSketch objects, using a Datasketches | ||
| * Union object. Throws an exception if sketches have different lgConfigK values and | ||
| * allowDifferentLgConfigK is set to false. | ||
| * Returns an encrypted value of `input` using AES in given `mode` with the specified `padding`. |
There was a problem hiding this comment.
@cboumalh There are a lot of diffs in this PR, making it somewhat difficult to verify that the changes only affect the Datasketches functions, e.g.
Do you think it could be possible to update the changes to avoid moving existing functions around as much as possible such that the diffs only show changes to function properties, rather than move invasive diffs of large blocks of functions updated/changed? This would make it easier and safer to review 🙏
There was a problem hiding this comment.
yep will look into this, the diff did not look like this in my IDE.
There was a problem hiding this comment.
fixed it as much as possible, I think the diff algorithm is just different than the one locally in the IDE, so it's out of my control for some files.
2 participants
What changes were proposed in this pull request?
Propagate the new grouping "sketch_funcs" to the rest of the files where datasketches are used. Reference PR: #54061
Why are the changes needed?
#54061 created a new group called sketch_funcs and moved them out the datasketch functions from misc_funcs group. The new grouping has not propagated through the whole codebase, so this is an attempt to do so
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
N/A