-
Notifications
You must be signed in to change notification settings - Fork 520
[SYSTEMDS-3800] Add tests to increase code coverage of FED instructions #2148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ng of federated weighted covariance instruction
…truction for the single-matrix-input case
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2148 +/- ##
============================================
+ Coverage 71.77% 71.84% +0.07%
- Complexity 43727 43757 +30
============================================
Files 1441 1441
Lines 165952 165971 +19
Branches 32383 32388 +5
============================================
+ Hits 119104 119242 +138
+ Misses 37572 37453 -119
Partials 9276 9276 ☔ View full report in Codecov by Sentry. |
|
LGTM - thanks for the additional tests and improved code coverage @gaturchenko. A minor thing for the future: please do not include the commits from previous PRs which creates lots of merge conflicts during the rebase/squash process. Instead I just picked the actual 3 new commits. Thanks. |
The tests for the following federated instructions have been added:
Central moment (weighted case)
Ternary aggregation (cumulative product & sumproduct)
Ternary instruction (account for non-literal scalar inputs)
The
TernaryFEDInstructionwas also slightly modified, since in its previous implementation theprocessMatrixScalarInputmethod returned an "unknown variable" error when processing anifelseinstruction with one matrix input and non-literal scalar inputs.