Skip to content

Conversation

@gaturchenko
Copy link
Contributor

The tests for the following federated instructions have been added:

Central moment (weighted case)
Ternary aggregation (cumulative product & sumproduct)
Ternary instruction (account for non-literal scalar inputs)
The TernaryFEDInstruction was also slightly modified, since in its previous implementation the processMatrixScalarInput method returned an "unknown variable" error when processing an ifelse instruction with one matrix input and non-literal scalar inputs.

@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.84%. Comparing base (58490d3) to head (54a12dc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...untime/instructions/fed/TernaryFEDInstruction.java 82.60% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2148      +/-   ##
============================================
+ Coverage     71.77%   71.84%   +0.07%     
- Complexity    43727    43757      +30     
============================================
  Files          1441     1441              
  Lines        165952   165971      +19     
  Branches      32383    32388       +5     
============================================
+ Hits         119104   119242     +138     
+ Misses        37572    37453     -119     
  Partials       9276     9276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboehm7
Copy link
Contributor

mboehm7 commented Dec 2, 2024

LGTM - thanks for the additional tests and improved code coverage @gaturchenko. A minor thing for the future: please do not include the commits from previous PRs which creates lots of merge conflicts during the rebase/squash process. Instead I just picked the actual 3 new commits. Thanks.

@mboehm7 mboehm7 closed this in 53cba12 Dec 2, 2024
fietenoer pushed a commit to fietenoer/systemds that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants