lmds test with tee operator and tsmm patches #2338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM - thanks @j143 for the reproducible test. During the merge I cleaned up the test and computation of expected results, and also removed the unnecessary compiler changes. I'll have a look to fix these issues today. |
Contributor
|
OK, the test is now working - besides incorrect metadata for reading the output matrix, it was due to a specific transpose rewrite that destroyed the OOC pipeline. This issue also pointed to additional primitives we need as well as much better exception handling (because currently OOC instructions spawn threads without waiting so exceptions from these threads never surface). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the resettable stream, the expectation is - are we going to load the whole X dataset or a sub part of it?
or like spark we shall load the necessary amount blocks enough to process the whole calculation few blocks at a time.