Skip to content

Conversation

@jessicapriebe
Copy link
Contributor

This patch adds a new out-of-core CTable instruction.

@mboehm7
Copy link
Contributor

mboehm7 commented Oct 25, 2025

LGTM - thanks for the patch @jessicapriebe. The ctable implementation looks pretty good. During the merge I only changed minor formatting issues.

@mboehm7 mboehm7 closed this in ebd3aed Oct 25, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SystemDS PR Queue Oct 25, 2025
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

❌ Patch coverage is 70.52632% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.26%. Comparing base (9e0a481) to head (3bdbefc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...runtime/instructions/ooc/CtableOOCInstruction.java 69.89% 19 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2342   +/-   ##
=========================================
  Coverage     72.26%   72.26%           
- Complexity    46711    46724   +13     
=========================================
  Files          1502     1503    +1     
  Lines        177162   177256   +94     
  Branches      34820    34832   +12     
=========================================
+ Hits         128021   128091   +70     
- Misses        39477    39494   +17     
- Partials       9664     9671    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants