-
Notifications
You must be signed in to change notification settings - Fork 520
[SYSTEMDS-3934] ooc eviction manager configurable partitions for spooling #2350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYSTEMDS-3934] ooc eviction manager configurable partitions for spooling #2350
Conversation
* also add missing lock for the cacheobject
* there's an issue with spillLocation get
|
Hi @mboehm7 , I have implemented for writing to partitions at once instead of each block at a time. this is an overkill for a simple LRU/FIFO, but with prescient policy in mind - I've arrived at this design. next timeline: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2350 +/- ##
============================================
- Coverage 72.27% 72.26% -0.01%
+ Complexity 46754 46742 -12
============================================
Files 1504 1505 +1
Lines 177324 177440 +116
Branches 34842 34853 +11
============================================
+ Hits 128162 128232 +70
- Misses 39491 39522 +31
- Partials 9671 9686 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM - thanks for the patch @j143 - yes, writing out entire partitions was the plan after the initial eviction manager. The next steps also sound very good. |
At present, adds the scaffold to introduce configurable partitions. For now,it does write only one block at a time.