Skip to content

Conversation

@j143
Copy link
Member

@j143 j143 commented Nov 4, 2025

At present, adds the scaffold to introduce configurable partitions. For now,it does write only one block at a time.

@j143
Copy link
Member Author

j143 commented Nov 6, 2025

Hi @mboehm7 , I have implemented for writing to partitions at once instead of each block at a time.

this is an overkill for a simple LRU/FIFO, but with prescient policy in mind - I've arrived at this design.

next timeline:
1/ I'll wrap up till this for my report presentation, in my report. (7th to 11th November)
2/ after this report presentation - I have a week, during which I'll run the experiments to present results in the viva (20th to 30th November)

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 75.64103% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.26%. Comparing base (e40bbfe) to head (df7ba43).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/runtime/instructions/ooc/OOCEvictionManager.java 76.12% 26 Missing and 11 partials ⚠️
...pache/sysds/runtime/util/PartitionFileManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2350      +/-   ##
============================================
- Coverage     72.27%   72.26%   -0.01%     
+ Complexity    46754    46742      -12     
============================================
  Files          1504     1505       +1     
  Lines        177324   177440     +116     
  Branches      34842    34853      +11     
============================================
+ Hits         128162   128232      +70     
- Misses        39491    39522      +31     
- Partials       9671     9686      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mboehm7
Copy link
Contributor

mboehm7 commented Nov 9, 2025

LGTM - thanks for the patch @j143 - yes, writing out entire partitions was the plan after the initial eviction manager. The next steps also sound very good.

@mboehm7 mboehm7 closed this in c7300f3 Nov 9, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SystemDS PR Queue Nov 9, 2025
janniklinde pushed a commit to janniklinde/systemds that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants