Skip to content

Add support for multiple and 2>n dimensional HDF5 Datasets #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
luccadibe wants to merge 11 commits into
base: main
Choose a base branch
from
+1,821 −365
Draft

Add support for multiple and 2>n dimensional HDF5 Datasets #2394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9b69e5b
test data generator for HDF5 Readers
luccadibe Dec 1, 2025
771a964
HDF5 Reader comprehensive tests
luccadibe Dec 1, 2025
cf7a037
clean up test
luccadibe Jan 5, 2026
1ccaff4
fix datatype test input
luccadibe Jan 5, 2026
4b36374
add filter pipeline and attribute message constants
luccadibe Jan 5, 2026
bead9dc
infer hdf5 format from .h5 file extension
luccadibe Jan 5, 2026
219f713
format
luccadibe Jan 5, 2026
5bceae1
add filter pipeline and attribute messages
luccadibe Jan 5, 2026
a69eff3
impl filter pipline
luccadibe Jan 5, 2026
3cafa1b
impl attribute
luccadibe Jan 5, 2026
c83b072
test passing and optimized hdf5 readers
luccadibe Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/org/apache/sysds/parser/DataExpression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,6 +1019,18 @@ public void validateExpression(HashMap<String, DataIdentifier> ids, HashMap<Stri
inferredFormatType = true;
}
}

// check if file is HDF5 format (by file extension)
if (formatTypeString == null && shouldReadMTD) {
formatTypeString = MetaDataAll.checkHasHDF5Format(inputFileName);
if (formatTypeString != null) {
addVarParam(FORMAT_TYPE, new StringIdentifier(formatTypeString, this));
configObj.setFormatTypeString(formatTypeString);
inferredFormatType = true;
// HDF5 doesn't require metadata file for dimension validation
shouldReadMTD = false;
}
}

if (formatTypeString != null && formatTypeString.equalsIgnoreCase(FileFormat.MM.toString())){
/*
Expand Down
Loading