THRIFT-5909: Added a special no-extension build to test the code paths without native extensions #3271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The build no no-extension job failed due to #3269 |
…mplementation
When binary extension is not available (for example, in JRuby), Thrift::Union
throws an unexpected NoMethodError instead of the intended error:
1) Union Thrift::Union should raise for wrong set field when hash initialized and type checking is off
Failure/Error: expect { Thrift::Serializer.new.serialize(union) }.to raise_error(RuntimeError, "set_field is not valid for this union!")
expected RuntimeError with "set_field is not valid for this union!", got #<NoMethodError: undefined method '[]' for nil> with backtrace:
# ./lib/thrift/union.rb:78:in 'write'
# ./lib/thrift/serializer/serializer.rb:29:in 'serialize'
# ./spec/union_spec.rb:54:in 'block in <main>'
# ./spec/union_spec.rb:54:in 'block in <main>'
# ./spec/union_spec.rb:54:in 'block in <main>'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When binary extensions are compiled and loaded, they replace Ruby implementation for some of of the core classes (structs, unions, and interestingly, compact protocol). This code is never tested when the binary extensions are present.
For example, #3269 provides a fix for one such discrepancy between native code and Ruby.
This PR introduces one special "no extensions" build to test pure Ruby code.
[skip ci]anywhere in the commit message to free up build resources.