Open
Conversation
bneradt
requested changes
Jan 28, 2026
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good. Thanks for helping us make progress on this.
bneradt
requested changes
Feb 4, 2026
Comment on lines
59
to
62
| process_regex_mapping_config(const char *from_host_lower, url_mapping *new_mapping, UrlRewrite::RegexMapping *reg_map) | ||
| { | ||
| std::string_view to_host{}; | ||
| int to_host_len; |
Contributor
There was a problem hiding this comment.
This looks like it has code duplicated with a function of the same name in RemapConfig.cc. Maybe we can extract out logic to a shared function to deduplicate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support YAML format for remap rules. Not replacing remap.config but providing additional remap option to define configs in yaml. If no
remap.yamlis found, defaults back toremap.config"Prerequisite" for #12669, to YAML'fy remap configs before moving into virtualhost.yaml