hrw4u: native C++ parser and visitor for header_rewrite#12825
Draft
zwoop wants to merge 4 commits intoapache:masterfrom
Draft
hrw4u: native C++ parser and visitor for header_rewrite#12825zwoop wants to merge 4 commits intoapache:masterfrom
zwoop wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
I'm making this a draft for now, I think it needs to go into ATS v11, since we're getting close to 10.2 branching and release. |
Contributor
Author
|
[approve ci debian] |
This also adds a new tool, and infrastructure, to allow us to compare and verify that an old and new (hrw4u) configuration generates the same structure of Statements and Operators (functional equivalence). That tool could also be used in an automation process migrating existing configurations to hrw4u. u4wrh: adds an option to disable optimizations
Fixes parser problems in u4wrh with implicit hooks.
This also fixes a few issues in the tool chains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This essentially converted the existing Python parser / visitor / emitters to C++ and natively calling the various factory functions to create the object structure. In addition, it adds a new testing tool, hrw_confcmp, which compares an old vs a hrw4u configuration, and make sure they both create the same set of objects. As such, the header_rewrite core also added some support to identify the various Operators and Conditions. Usage: