Conversation
| #include "tscore/ink_config.h" | ||
|
|
||
| #ifdef HAVE_SYS_ENDIAN_H | ||
| #if !defined(darwin) |
There was a problem hiding this comment.
Old versions of macOS didn't have be64toh and the other functions, but now those are defined on endian.h, and those cause errors due to duplication.
I could add a check for the availability of those functions, but this small change is enough. We don't have this issue on newer codebase.
|
|
||
| AC_MSG_CHECKING([for C compiler version]) | ||
| # Capture the output of the compiler version command | ||
| ac_cv_c_compiler_version=`${CC} --version 2>&1 | grep "Apple clang version" | head -n 1 | awk '{print $4}' | cut -d'.' -f1` |
There was a problem hiding this comment.
This is hacky and only works for Apple Clang 17, but I don't think we will need to maintain it for a long time.
bryancall
left a comment
bryancall
left a comment
There was a problem hiding this comment.
Review: LGTM - Tested on macOS 26.2 with Apple clang 17.0.0
Build tested successfully. All three changes are appropriate:
1. configure.ac - Compiler Version Detection
- Correctly extracts Apple clang major version (17)
- Conditionally adds
-Wno-cast-function-type-mismatchonly for clang 17 - Also adds
-Wno-vla-extensionwhich is needed
Verified the detection works:
checking for C compiler version... 17
AM_CFLAGS: ... -Wno-cast-function-type-mismatch ...
2. ink_endian.h - Skip sys/endian.h on darwin
macOS already provides byte-order functions via <libkern/OSByteOrder.h> (lines 43-75). On macOS 26, sys/endian.h exists but conflicts. The #if !defined(darwin) guard correctly prevents the conflict.
3. QUICNetVConnection.cc - Remove unused frame_count
The variable was declared but never used. Clang 17 with -Werror treats this as an error.
Full build completed without errors.
github-project-automation
bot
moved this from In progress
to Ready to Merge
in 9.2.x Branch and Release
|
@ezelkow1 I'll leave this open for you not to mess up the ongoing release process. I believe the Milestone needs to be updated to 9.2.13. Please push the merge button when you are ready. |
3 participants
Adding
-Wno-cast-function-type-mismatchisn't great, but I don't think we should make changes that this check may find, on 9.2.x.