Skip to content

Conversation

@guan404ming
Copy link
Member

Why

The llvm_target() function reads /proc/cpuinfo which only exists on Linux, causing tests to fail on macOS with FileNotFoundError.

How

  • Add cross-platform CPU feature detection in llvm_target() using platform.system() and sysctl for macOS
  • Update tests

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical compatibility issue in the PyTorch Dynamo frontend, specifically for macOS users. It refactors the CPU feature detection mechanism to be platform-aware, ensuring that the system can correctly identify and utilize available CPU instructions without encountering errors on non-Linux environments. This change broadens the usability of the PyTorch Dynamo frontend across different operating systems.

Highlights

  • macOS Compatibility Fix: The llvm_target() function, which previously relied on /proc/cpuinfo (a Linux-specific file), now includes cross-platform CPU feature detection to prevent FileNotFoundError on macOS.
  • Cross-Platform CPU Detection: Implemented platform-specific logic within llvm_target(): for Linux, it continues to read /proc/cpuinfo, while for macOS (Darwin), it utilizes sysctl -n machdep.cpu.features to determine CPU capabilities like AVX512 or AVX2. A fallback to 'llvm' is provided for ARM64 macOS and other cases.
  • Test Updates: Existing tests for the PyTorch Dynamo frontend were updated to reflect changes in expected output, specifically regarding the order of elements in a returned tuple and constant types within subgraph_0, and parameter/variable naming consistency in subgraph_1.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a compatibility issue on macOS by making the llvm_target() function cross-platform. The changes correctly use platform.system() to differentiate between Linux and Darwin, and employ sysctl on macOS to detect CPU features. This resolves the FileNotFoundError for /proc/cpuinfo on non-Linux systems. The test updates also seem appropriate to align with the new logic. I have one suggestion to improve the maintainability and robustness of the llvm_target function.

@guan404ming guan404ming marked this pull request as ready for review December 27, 2025 20:34
@guan404ming
Copy link
Member Author

cc @tlopex @mshr-h

@mshr-h mshr-h merged commit 7db7a91 into apache:main Dec 28, 2025
13 checks passed
@guan404ming guan404ming deleted the fix-torch-dynamo-mac branch December 31, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants