-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Relax][PyTorch] Fix PyTorch Dynamo frontend for Darwin compatibility #18619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical compatibility issue in the PyTorch Dynamo frontend, specifically for macOS users. It refactors the CPU feature detection mechanism to be platform-aware, ensuring that the system can correctly identify and utilize available CPU instructions without encountering errors on non-Linux environments. This change broadens the usability of the PyTorch Dynamo frontend across different operating systems. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a compatibility issue on macOS by making the llvm_target() function cross-platform. The changes correctly use platform.system() to differentiate between Linux and Darwin, and employ sysctl on macOS to detect CPU features. This resolves the FileNotFoundError for /proc/cpuinfo on non-Linux systems. The test updates also seem appropriate to align with the new logic. I have one suggestion to improve the maintainability and robustness of the llvm_target function.
Why
The llvm_target() function reads
/proc/cpuinfowhich only exists onLinux, causing tests to fail onmacOSwith FileNotFoundError.How