Skip to content

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Dec 27, 2025

Why

Flaky in CI due to numerical precision errors in gradient checks.
ref: #18575

How

  • Reduce input range from (0, 3) to (0, 2) to minimize floating-point errors

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a persistent flakiness issue observed in the test_conv2d gradient numeric test within the continuous integration environment. The root cause was identified as numerical precision errors during gradient checks. By narrowing the input data range used in the test, the changes mitigate these floating-point inaccuracies, thereby enhancing the reliability and stability of the test suite.

Highlights

  • Flaky Test Fix: Addressed a flaky test_conv2d gradient numeric test that was failing in CI due to numerical precision errors.
  • Input Range Reduction: Reduced the input data range for the conv2d gradient check from (0, 3) to (0, 2) to minimize floating-point errors and improve test stability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@guan404ming guan404ming changed the title Fix flaky test_conv2d gradient numeric test [Relax] Fix flaky test_conv2d gradient numeric test Dec 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a flaky test in test_conv2d by reducing the input data range to mitigate numerical precision errors during gradient checks. The change reduces the upper bound of the random data from 3 to 2. My review points out a discrepancy between the implementation and the pull request description, which states the range should be reduced to (0, 1). I've suggested aligning the code with the description to further enhance test stability.

@guan404ming guan404ming marked this pull request as ready for review December 27, 2025 07:36
@guan404ming
Copy link
Member Author

guan404ming commented Dec 27, 2025

cc @tlopex @mshr-h

@mshr-h mshr-h merged commit 5015047 into apache:main Dec 27, 2025
15 of 18 checks passed
@guan404ming guan404ming deleted the fix-flasky-con2d-test branch January 4, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants