fix: handle TimeoutError in Actor __aexit__ to prevent resource leaks#776
Merged
fix: handle TimeoutError in Actor __aexit__ to prevent resource leaks#776
Conversation
When Actor cleanup exceeded `_cleanup_timeout`, the unhandled `TimeoutError` from `asyncio.wait_for` left the Actor in a broken state: `_is_initialized` was never reset, event/charging managers were left partially shut down, and `sys.exit()` was never called. Now the timeout is caught and critical resource cleanup (event manager, charging manager) is attempted even after timeout. `_is_initialized` is reset in a `finally` block to guarantee consistent state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
added
adhoc
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #776 +/- ##
==========================================
- Coverage 81.91% 81.86% -0.06%
==========================================
Files 46 46
Lines 2693 2696 +3
==========================================
+ Hits 2206 2207 +1
- Misses 487 489 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
janbuchar
reviewed
Feb 11, 2026
Removed the forced __aexit__ calls on event_manager and charging_manager after timeout - if finalize() timed out, those calls would likely hang too. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
janbuchar
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_cleanup_timeout, the unhandledTimeoutErrorfromasyncio.wait_forleft the Actor in a broken state_is_initializedwas never reset toFalse, event/charging managers could be left partially shut down, andsys.exit()was never called even when_exit_processwasTrueTimeoutErroris caught, critical resource cleanup (event manager, charging manager) is forced even after timeout, and_is_initializedis always reset via afinallyblockTest plan
_cleanup_timeoutand a slow event listener to confirm the timeout path logs a warning and still completes shutdown cleanly🤖 Generated with Claude Code