test: Increase total test coverage and reduce E2E tests #783
+1,751
−1,036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdusek
force-pushed
the
test/reduce-e2e-increase-coverage
branch
from
3302fdb to
2b54d26
Compare
github-actions
bot
added
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #783 +/- ##
==========================================
- Coverage 81.86% 72.57% -9.29%
==========================================
Files 46 46
Lines 2696 2695 -1
==========================================
- Hits 2207 1956 -251
- Misses 489 739 +250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
force-pushed
the
test/reduce-e2e-increase-coverage
branch
2 times, most recently
from
989dd15 to
0f1ff9a
Compare
This was referenced Feb 12, 2026
Move 24 e2e tests that only exercise storage APIs or SDK logic to integration tests (real API, no Actor deployment). Delete 4 e2e tests already covered by existing unit/integration tests. Add 47 new unit tests covering ChargingManager, SmartApifyStorageClient, AliasResolver, ApifyEventManager, Configuration, crypto utilities, and Pydantic models. E2E: 65 -> 37 (-43%), Integration: 40 -> 102, Unit: 127 -> 295 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… utilities Add 43 new unit tests targeting uncovered branches and code paths: - 14 tests for _actor.py (webhooks, timeouts, push_data, event listeners, abort, remaining_time) - 16 tests for storage clients (API client creation validation, KVS operations, dataset operations) - 5 tests for _utils.py (IPython detection, enum extraction) - 3 tests for _crypto.py (invalid key types, non-dict input) - 3 tests for _proxy_configuration.py (unparseable URL, min_length, apify domain warning) - 2 tests for log.py (DEBUG/INFO level configuration) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These tests (max_crawl_depth, max_requests_per_crawl, max_request_retries) only exercise Crawlee functionality and don't test any Apify SDK integration. Crawlee is responsible for testing its own features. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix copy-paste bug in request queue tests (was testing KVS instead of RQ), replace fragile index-based log assertions with content-based filtering, strengthen weak delegation tests to verify arguments, and improve test isolation with monkeypatch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The original strict assertions (exact count, initialization log messages, index-based ordering) are valid and more thorough. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…g test - Parametrize copy-pasted webhook, timedelta timeout, and invalid timeout tests for start/call/call_task into 3 tests with 3 variants each - Remove duplicate test_actor_handles_migrating_event_correctly from test_actor_lifecycle.py (already covered in test_apify_event_manager.py) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
force-pushed
the
test/reduce-e2e-increase-coverage
branch
from
58222aa to
6048ac8
Compare
Pijukatel
requested changes
Feb 13, 2026
Contributor
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
Sme small test related comments
Contributor
Author
|
@janbuchar, @Mantisus - not necessary requesting a review, up to you guys, mostly just to keep you informed about the SDK test suite improvements. |
- Parametrize tests with multiple assertions into single-assert-per-case - Remove redundant service_locator._configuration = None (handled by autouse fixture) - Inject mocked API clients to avoid accessing private _api_client attribute - Move drop() calls into finally blocks for cleanup on test failure - Always include is_running_in_ipython flag in get_system_info (True/False) - Remove duplicate assert in test_create_same_hmac - Remove unnecessary type: ignore comment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ApifyEventManager,Configuration, crypto utilities, and more.test_actor_handles_migrating_event_correctlyfromtest_actor_lifecycle.py- same behavior is already tested intest_apify_event_manager.py::test_migrating_event_triggers_persist_state.Issue
Test count changes
Test plan