test: skip flaky test_request_deduplication_edge_cases[shared]
#787
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #787 +/- ##
===========================================
- Coverage 81.86% 68.02% -13.84%
===========================================
Files 46 46
Lines 2696 2696
===========================================
- Hits 2207 1834 -373
- Misses 489 862 +373
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
changed the title
test_request_deduplication_edge_cases[shared]
Crawlee's RequestQueue.add_request() crashes with IndexError when the platform API returns an empty processed_requests list in shared access mode. Skip until the upstream bug is fixed. See #786 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The `request.param` attribute is only available inside parameterized fixtures, not in the test function itself where `request` is a `TopRequest`. Use `request.node.callspec.params` instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instead of skipping both single and shared variants, only skip the shared variant which is affected by the Crawlee bug. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #786.