feat: Migrate to Scrapy's native AsyncCrawlerRunner#793
Draft
feat: Migrate to Scrapy's native AsyncCrawlerRunner#793
Conversation
Adopt Scrapy 2.14's AsyncCrawlerRunner to eliminate the Deferred conversion layer (deferred_to_future). The run_scrapy_actor function now handles asyncio reactor installation internally, removing boilerplate from user code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
t-tooling
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #793 +/- ##
==========================================
- Coverage 85.46% 85.45% -0.01%
==========================================
Files 46 46
Lines 2697 2696 -1
==========================================
- Hits 2305 2304 -1
Misses 392 392
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
changed the title
Scrapy 2.14+ deprecated the spider argument in process_item() and newer versions no longer pass it, causing TypeError in PriceCleanerPipeline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AsyncCrawlerRunnerto eliminate thedeferred_to_futureconversion layer.run_scrapy_actornow handlesinstall_reactorinternally, removing boilerplate from user code.Issue
AsyncCrawlerRunnerand/orAsyncCrawlerProcess#638Test plan